da_revocation: sample revoked DACs and PAI certs for VID:0xFFF1 PID:0x8001 #36838
Conversation
created the PAI using chip-cert by using
credentials/test/attestation/Chip-Test-PAA-FFF1-{Cert,Key}.pem as
the signing CA.
created the DAC (vid: 0xFFF1, pid: 0x8001) using the generated PAI
Revoked the PAI and created the CRL for the same.
0xFFF1 and PID 0x8001 created the DAC using chip-cert by using credentials/development/attestation/Matter-Development-PAI-FFF1-noPID-Cert.pem as the signing CA. Revoked the DAC and created CRL for the same.
|
Review changes with |
|
PR #36838: Size comparison from 9e203e2 to c24a766 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
- Please rename
SingedtoSignedeverywhere.
| @@ -0,0 +1,13 @@ | |||
| -----BEGIN CERTIFICATE----- | |||
There was a problem hiding this comment.
Please wait for a review by @bh3000 befire merging.
There was a problem hiding this comment.
Could you add a set of CRLs and certs for the indirect CRL signing use case as well?
For complete test/example coverage there needs to be versions that includes the CRL entry extension Certificate Issuer as well. Note that there are two approaches here that should be included, the case where each entry has the Certificate Issuer, and the case where the entry's are grouped by Certificate Issuer (multiple entries with the same Certificate Issuer where only the first in the group contain the extension). See section 6.2.4.1. Step 10.a. and RFC 5280 section 5.3.3 for detail.
Can you add those?
credentials/development/attestation/Matter-Development-PAI-FFF1-noPID-CRL.pem
Show resolved
Hide resolved
There was a problem hiding this comment.
The CRLs have to be regenerated with the Authority Key Identifier extension matching the CRLSignerCertificates Subject Key Identifier.
There was a problem hiding this comment.
To add this you can update the ca.conf you use to include:
[ crl_ext ]
authorityKeyIdentifier=keyid:always
and within the [ ca ], or where the default_ca points to add:
crl_extensions = crl_ext
This can be done in a separate PR. No need to do here. |
There was a problem hiding this comment.
@shubhamdp please add a Testing entry in the summary of this PR and explain how this change was tested.
Since I see no unit test changes, I assume this will be "manually tested via..." and in that case we would like to intentionally set the bar higher on manual tests (to avoid all PRs setting manual because it is easier) so please spend time to add details on how this was tested as well as a justification why it is impossible for this PR to be tested in an automated fashion.
Related to #26582
Generated the certificates with the help of
chip-cert(please check the commands used below).Generated and updated CRL using
openssl cafunctionality.Next update time is set to 99 years.
chip-cert commands used for generating DACs
chip-cert commands used for generating PAI and DAC